Skip to content

Fix tests after framework version bump - #300

Merged
swissspidy merged 2 commits into
mainfrom
fix/tests
Aug 4, 2026
Merged

Fix tests after framework version bump#300
swissspidy merged 2 commits into
mainfrom
fix/tests

Conversation

@swissspidy

@swissspidy swissspidy commented Aug 4, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Tests
    • Updated scaffolding expectations to reflect the WP-CLI 3.0 requirement.
    • Revised generated README and Composer dependency checks for default, branch, shield, alias, and license scenarios.

@swissspidy swissspidy added this to the 3.0.1 milestone Aug 4, 2026
Copilot AI lite review requested due to automatic review settings August 4, 2026 15:28
@swissspidy swissspidy added the scope:testing Related to testing label Aug 4, 2026
@swissspidy
swissspidy requested a review from a team as a code owner August 4, 2026 15:28
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@swissspidy, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 52 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: edf70dee-ebbc-48e7-9964-40eb69ba47f1

📥 Commits

Reviewing files that changed from the base of the PR and between 3d91791 and 9af3510.

📒 Files selected for processing (2)
  • README.md
  • src/ScaffoldPackageCommand.php
📝 Walkthrough

Walkthrough

The feature fixtures now expect scaffolded packages and generated README files to require WP-CLI 3.0 instead of WP-CLI 2.13.

Changes

Scaffold version expectations

Layer / File(s) Summary
Update scaffold version fixtures
features/scaffold-package.feature, features/scaffold-package-readme.feature
Updated Composer requirements from ^2.13 to ^3.0 and README installation text from v2.13 to v3.0 across the scaffold scenarios.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: copilot

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the test updates required after the framework version bump.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@features/scaffold-package.feature`:
- Around line 45-47: Restore the fixture expectations to the current scaffold
default: in features/scaffold-package.feature lines 45-47, expect ^2.13 instead
of ^3.0; in features/scaffold-package-readme.feature lines 41-44 and 81-84,
expect v2.13 instead of v3.0. Keep the scaffold implementation unchanged unless
its default is intentionally being updated.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e2e80848-9828-4153-887d-d1d60e6ee1cc

📥 Commits

Reviewing files that changed from the base of the PR and between 64d2a1d and 3d91791.

📒 Files selected for processing (2)
  • features/scaffold-package-readme.feature
  • features/scaffold-package.feature

Comment thread features/scaffold-package.feature

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Behat acceptance test expectations to reflect a WP-CLI 3.0 baseline after the framework version bump, primarily by adjusting expected scaffolded output (composer constraints and generated README wording).

Changes:

  • Bumped expected scaffolded composer.json WP-CLI requirement from ^2.13 to ^3.0.
  • Updated expected generated README wording to state “WP-CLI v3.0 or greater”.
  • Updated multiple scaffold-package-readme scenarios’ embedded composer.json expectations to ^3.0.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
features/scaffold-package.feature Updates expected scaffolded package composer.json WP-CLI version constraint to ^3.0.
features/scaffold-package-readme.feature Updates expected generated README wording and embedded composer.json requirements to WP-CLI v3.0+ / ^3.0.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread features/scaffold-package.feature
Comment thread features/scaffold-package-readme.feature
@swissspidy
swissspidy merged commit 19e01e8 into main Aug 4, 2026
72 of 175 checks passed
@swissspidy
swissspidy deleted the fix/tests branch August 4, 2026 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants